[No QA] Add Spend Rules documentation to help site by MelvinBot · Pull Request #87439 · Expensify/App

MelvinBot · 2026-04-09T01:07:27Z

Summary

Adds a new Spend Rules section to the Workspace Rules help article documenting the feature added in Add spend rule base page #86684
Documents built-in card protection (always-on blocking of Adult services, ATMs, Gambling, Money transfers)
Documents how to create custom Spend Rules with Allow/Block restriction types, merchant matching, spend categories, and max amounts
Updates the Set Up and Manage the Expensify Card article to cross-reference Spend Rules
Updates metadata keywords for improved search discoverability

Test plan

Verify the Workspace Rules article renders correctly on the help site
Verify the new Spend Rules section follows the existing article structure
Verify the cross-link from the Expensify Card article works correctly
Verify all UI labels match the actual product (Restriction type, Allow, Block, Spend category, Max amount, etc.)

Add a new section documenting Spend Rules for Expensify Cards, including built-in protection and custom rule creation. Update the Expensify Card setup article to cross-reference Spend Rules. Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>

…SiteDocs Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>

github-actions · 2026-04-09T01:09:32Z

HelpDot Documentation Review

Overall Assessment

This PR adds a well-structured Spend Rules section to the Workspace Rules article and updates the Expensify Card article with a cross-reference. The new content is clear, actionable, and follows most governance conventions. A few issues need attention, primarily around link formatting and heading level.

Scores Summary

Readability: 9/10 - Steps are sequential, clear, and action-oriented. The distinction between Allow and Block restriction types is well explained. The built-in protection list is concise and scannable.
AI Readiness: 8/10 - Keywords and internalScope are updated with relevant spend-rule phrases. Headings are task-based and include the feature name. The new # heading follows the existing article pattern but technically violates the one-#-heading rule.
Style Compliance: 7/10 - UI terminology and button names are correctly bolded and cased. Navigation instructions use the correct unified format. However, both cross-links use absolute URLs instead of the required relative links.

Key Findings

Absolute URLs instead of relative links: Both changed files use full https://help.expensify.com/... URLs. Per HELP_AUTHORING_GUIDELINES.md Section 7 ("Link Formatting"), articles must use relative links only. This applies to the new Spend Rules cross-link in Set-Up-and-Manage-the-Expensify-Card.md and the link to the Expensify Card article within the new Spend Rules section of Workspace-Rules.md.
Multiple # headings: The new # How to configure Spend Rules for Expensify Cards heading is a #-level heading. The authoring guidelines specify exactly one # heading (the article title) plus an optional # FAQ. This is consistent with the existing article's pattern (which already uses multiple # headings for other rule sections), so this is a pre-existing structural issue rather than something newly introduced -- but worth noting for future cleanup.
Positive: Strong step formatting -- The "How to add a custom Spend Rule" section has well-structured numbered steps with clear actions, correct bold formatting on UI elements, and helpful sub-bullets explaining Allow vs. Block behavior.
Positive: Good metadata updates -- The keywords and internalScope additions are relevant and reflect real search queries (e.g., "spend rules", "block card transactions", "card spending restrictions").
Screenshot placeholder follows the correct HTML comment format per Section 8 of the authoring guidelines.

Recommendations

Convert absolute URLs to relative links in both files. For example, change https://help.expensify.com/articles/new-expensify/workspaces/Workspace-Rules to a relative path like /articles/new-expensify/workspaces/Workspace-Rules.
Consider demoting # to ## for the new Spend Rules heading to align with the governance rule of one # heading per article. This would be a larger change affecting the whole file's structure, so it may be better addressed in a separate cleanup PR.

Files Reviewed

docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md -- One-line change adding Spend Rules cross-reference. Uses absolute URL (should be relative).
docs/articles/new-expensify/workspaces/Workspace-Rules.md -- New 43-line Spend Rules section with metadata updates. Well-structured content; uses absolute URL for cross-link (should be relative).

Note: This review covers only the proposed changes in the PR diff, not pre-existing content.

github-actions · 2026-04-09T01:09:33Z

docs/articles/new-expensify/workspaces/Workspace-Rules.md


 ---

+# How to configure Spend Rules for Expensify Cards


Heading hierarchy violation: Per HELP_AUTHORING_GUIDELINES.md Section 4, an article may have exactly one # heading (the article title), plus an optional # FAQ. All other sections must use ##. This should be ## How to configure Spend Rules for Expensify Cards.

(Note: The existing article already uses multiple # headings for other sections, which is a pre-existing issue -- but new content should follow the governance standard.)

github-actions · 2026-04-09T01:09:35Z

docs/articles/new-expensify/workspaces/Workspace-Rules.md

+
+Spend Rules let you approve or decline Expensify Card transactions in real time based on merchants, spend categories, or transaction amounts. Use them to control where and how company cards are used.
+
+**Note:** Spend Rules require the **Expensify Card** to be enabled on the workspace. To learn how to set up the Expensify Card, see [Set Up and Manage the Expensify Card](https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card).


Cross-linking violation: Per HELP_AUTHORING_GUIDELINES.md Section 7, use relative links only -- do not use full URLs.

Replace:

[Set Up and Manage the Expensify Card](https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card)

With:

[Set Up and Manage the Expensify Card](/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card)

github-actions · 2026-04-09T01:09:37Z

docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md

 - Optional expiration dates for time-bound spending
 - Custom names for easier categorization
- Spend restrictions by employee and merchant
+- Spend restrictions by employee, merchant, and category via [Spend Rules](https://help.expensify.com/articles/new-expensify/workspaces/Workspace-Rules)


Cross-linking violation: Per HELP_AUTHORING_GUIDELINES.md Section 7, use relative links only -- do not use full URLs.

Replace:

[Spend Rules](https://help.expensify.com/articles/new-expensify/workspaces/Workspace-Rules)

With:

[Spend Rules](/articles/new-expensify/workspaces/Workspace-Rules)

github-actions · 2026-04-09T01:09:41Z

docs/articles/new-expensify/workspaces/Workspace-Rules.md

+
+**Note:** Spend Rules require the **Expensify Card** to be enabled on the workspace. To learn how to set up the Expensify Card, see [Set Up and Manage the Expensify Card](https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card).
+
+## What built-in protection Expensify Cards include


Heading hierarchy issue: If the parent # heading on line 88 is demoted to ## (as it should be per governance), this ## sub-heading would need to become a different structural approach. Since governance prohibits ### headings, consider either:

Keeping this as ## and removing the parent # grouping (making it a peer section), or

Integrating this content into the parent section without a separate heading.

OSBotify · 2026-04-09T01:15:39Z

A preview of your ExpensifyHelp changes have been deployed to https://63477e96.helpdot.pages.dev ⚡️

Updated articles:

MelvinBot and others added 2 commits April 9, 2026 01:06

Merge remote-tracking branch 'origin/main' into claude-spendRulesHelp…

055c7f8

…SiteDocs Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>

MelvinBot assigned luacmartins Apr 9, 2026

MelvinBot requested a review from stephanieelliott as a code owner April 9, 2026 01:07

MelvinBot mentioned this pull request Apr 9, 2026

Add spend rule base page #86684

Merged

62 tasks

github-actions bot reviewed Apr 9, 2026

View reviewed changes

github-actions bot changed the title ~~Add Spend Rules documentation to help site~~ [No QA] Add Spend Rules documentation to help site Apr 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Add Spend Rules documentation to help site#87439

[No QA] Add Spend Rules documentation to help site#87439
MelvinBot wants to merge 2 commits intomainfrom
claude-spendRulesHelpSiteDocs

MelvinBot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot Apr 9, 2026

Uh oh!

github-actions bot Apr 9, 2026

Uh oh!

github-actions bot Apr 9, 2026

Uh oh!

github-actions bot Apr 9, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		Spend Rules let you approve or decline Expensify Card transactions in real time based on merchants, spend categories, or transaction amounts. Use them to control where and how company cards are used.

		Note: Spend Rules require the Expensify Card to be enabled on the workspace. To learn how to set up the Expensify Card, see [Set Up and Manage the Expensify Card](https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card).


		Note: Spend Rules require the Expensify Card to be enabled on the workspace. To learn how to set up the Expensify Card, see [Set Up and Manage the Expensify Card](https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card).

		## What built-in protection Expensify Cards include

Conversation

MelvinBot commented Apr 9, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Apr 9, 2026

HelpDot Documentation Review

Overall Assessment

Scores Summary

Key Findings

Recommendations

Files Reviewed

Uh oh!

github-actions bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants